Verify the NooBaa DB PostreSQL version at upgrade #10440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagihirshfeld
added
Needs Testing
sagihirshfeld
requested review from
ebenahar,
keesturam,
nehaberry and
mashetty330
ocs-ci
reviewed
Sep 8, 2024
sagihirshfeld
added
Verified
sagihirshfeld
changed the title
sagihirshfeld
force-pushed
the
verify-nb-db-psql-version
branch
from
32ad045
to
44d834d
Compare
sagihirshfeld
force-pushed
the
verify-nb-db-psql-version
branch
from
a2277b0
to
f426583
Compare
udaysk23
previously approved these changes
Oct 17, 2024
Signed-off-by: Sagi Hirshfeld <[email protected]>
Signed-off-by: Sagi Hirshfeld <[email protected]>
sagihirshfeld
force-pushed
the
verify-nb-db-psql-version
branch
from
f426583
to
44f3048
Compare
udaysk23
approved these changes
Nov 4, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sagihirshfeld, udaysk23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticeable changes made:
get_nb_db_psql_version_from_image: extract the version from the image name in the noobaa-db-pg statefulset. The equivalent of:query_nb_db_psql_version: Extract the version from the DB itself. The equivalent of:get_expected_nb_db_psql_version: Extract the PostreSQL version that's listed at the NooBaa CR, which by the noobaa-db reocvery KCS, seems to set the expectation. This util function is the equivalent of the following command:Added the
verify_nb_db_psql_versionhelper function, and added it to the verification inrun_ocs_upgrade.Added a libtest to test
verify_nb_db_psql_version